Change in osmo-msc[master]: Constify trans_assign_trans_id() parameters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 2 11:39:12 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12447 )

Change subject: Constify trans_assign_trans_id() parameters
......................................................................


Patch Set 1:

> Why do we need this change? Which problems it would solve?

It makes reading code easier because this patch makes it obvious from the function signature that function does not change its parameters without the need to read entire function.


-- 
To view, visit https://gerrit.osmocom.org/12447
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If002a1ff6ba4218cc16592946798340fcb1852ae
Gerrit-Change-Number: 12447
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 02 Jan 2019 11:39:12 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190102/dce3d20d/attachment.htm>


More information about the gerrit-log mailing list