This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has uploaded this change for review. ( https://gerrit.osmocom.org/13052 Change subject: EDGE tests: remove no-op check ...................................................................... EDGE tests: remove no-op check The headerTypeControl() function always return constant and is only used inside OSMO_ASSERT() which compares it to the very same constant which makes it no-op. Let's remove this clutter. Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4 --- M src/gprs_coding_scheme.h M tests/edge/EdgeTest.cpp 2 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/52/13052/1 diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h index 76cab0f..62cbb85 100644 --- a/src/gprs_coding_scheme.h +++ b/src/gprs_coding_scheme.h @@ -107,7 +107,6 @@ uint8_t optionalPaddingBits() const; const char *name() const; HeaderType headerTypeData() const; - HeaderType headerTypeControl() const; Family family() const; static GprsCodingScheme getBySizeUL(unsigned size); @@ -154,11 +153,6 @@ return (isGprs() && o.isGprs()) || (isEgprs() && o.isEgprs()); } -inline GprsCodingScheme::HeaderType GprsCodingScheme::headerTypeControl() const -{ - return HEADER_GPRS_CONTROL; -} - inline GprsCodingScheme::GprsCodingScheme(Scheme s) : m_scheme(s) { diff --git a/tests/edge/EdgeTest.cpp b/tests/edge/EdgeTest.cpp index 6ce2334..0cb123e 100644 --- a/tests/edge/EdgeTest.cpp +++ b/tests/edge/EdgeTest.cpp @@ -170,8 +170,6 @@ /* Check header types */ OSMO_ASSERT(current_cs.headerTypeData() == GprsCodingScheme::HEADER_GPRS_DATA); - OSMO_ASSERT(current_cs.headerTypeControl() == - GprsCodingScheme::HEADER_GPRS_CONTROL); check_coding_scheme(current_cs, GprsCodingScheme::GPRS); } -- To view, visit https://gerrit.osmocom.org/13052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4 Gerrit-Change-Number: 13052 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190226/09055f31/attachment.htm>