Change in osmo-ttcn3-hacks[master]: PCU: Add test for SNS Change Weight procedure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 26 10:23:05 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13027 )

Change subject: PCU: Add test for SNS Change Weight procedure
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13027/1/pcu/PCU_Tests_RAW_SNS.ttcn
File pcu/PCU_Tests_RAW_SNS.ttcn:

https://gerrit.osmocom.org/#/c/13027/1/pcu/PCU_Tests_RAW_SNS.ttcn@99
PS1, Line 99: 	NSCP[idx].send(t_NS_Send(g_ns_conn_id[idx], ts_SNS_CHG_WEIGHT(g_nsconfig[idx].nsei, 25, v4)));
> Is g_nsconfig[idx].nsei correct? Shouldn't it be g_nsconfig[idx_chg]. […]
g_nsconfig[idx_chg] should be correct.  However, the NSEI is actually identical across all conigurations, at least in sane/valid scenarios where *one* BSS is adressed.  WE just historically didn't have multiple NS-VCs so we had one NSEI per NS-VC.

"idx" is the index of the NS-VC through which the SNS message is to be sent, which can be any of the NS-VCs there are between the BSS and SGSN.  "idx_chg" is the index of the [same or other] NS-VC that we want to change.



-- 
To view, visit https://gerrit.osmocom.org/13027
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia63865139f63969ccde010b01ddb8fb073209f3a
Gerrit-Change-Number: 13027
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Feb 2019 10:23:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190226/ebdb3dd6/attachment.htm>


More information about the gerrit-log mailing list