Change in osmo-pcu[master]: Rewrite Packet Downlink Assignment

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12954 )

Change subject: Rewrite Packet Downlink Assignment
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/12954/6/src/encoding.cpp
File src/encoding.cpp:

https://gerrit.osmocom.org/#/c/12954/6/src/encoding.cpp@104
PS6, Line 104: static inline bool write_tai(bitvec *dest, unsigned& wp, int8_t tai)
> I don't understand the idea behind wp since it is that same value as dest->cur_bit

No it's not. I know it's counter-intuitive and that's one of the motivation to replace wp-based functions in this patch series. So eventually this function will go away naturally once it's no longer needed.



-- 
To view, visit https://gerrit.osmocom.org/12954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie180733d2584ebb16fb80b84526d0dbc70e3d441
Gerrit-Change-Number: 12954
Gerrit-PatchSet: 6
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 25 Feb 2019 15:16:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190225/e88282e1/attachment.htm>