Change in osmo-msc[master]: libmsc/sgs_vty.c: fix dead array comparation against null

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13017


Change subject: libmsc/sgs_vty.c: fix dead array comparation against null
......................................................................

libmsc/sgs_vty.c: fix dead array comparation against null

Comparing an array to null is not useful: sgs->cfg.vlr_name,
since the expression will always evaluate as true.

Change-Id: If045e42fca0315b0777eb86c44bf934ce58b340b
Fixes: CID#190871 Array compared against 0 (NO_EFFECT)
---
M src/libmsc/sgs_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/17/13017/1

diff --git a/src/libmsc/sgs_vty.c b/src/libmsc/sgs_vty.c
index 5b26178..cbe9370 100644
--- a/src/libmsc/sgs_vty.c
+++ b/src/libmsc/sgs_vty.c
@@ -160,9 +160,9 @@
 	vty_out(vty, "sgs%s", VTY_NEWLINE);
 	if (sgs->cfg.local_port != SGS_PORT_DEFAULT)
 		vty_out(vty, " local-port %u%s", sgs->cfg.local_port, VTY_NEWLINE);
-	if (sgs->cfg.local_addr)
+	if (strcmp(sgs->cfg.local_addr, DEFAULT_SGS_SERVER_IP))
 		vty_out(vty, " local-ip %s%s", sgs->cfg.local_addr, VTY_NEWLINE);
-	if (sgs->cfg.vlr_name)
+	if (strcmp(sgs->cfg.vlr_name, DEFAULT_SGS_SERVER_VLR_NAME))
 		vty_out(vty, " vlr-name %s%s", sgs->cfg.vlr_name, VTY_NEWLINE);
 
 	for (i = 0; i < ARRAY_SIZE(sgs->cfg.timer); i++) {

-- 
To view, visit https://gerrit.osmocom.org/13017
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If045e42fca0315b0777eb86c44bf934ce58b340b
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190223/61e4fb5e/attachment.htm>