Change in osmo-ttcn3-hacks[master]: RTP_Emulation: check received RTP packets

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/13000 )

Change subject: RTP_Emulation: check received RTP packets
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/13000/1/library/RTP_Emulation.ttcn
File library/RTP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/13000/1/library/RTP_Emulation.ttcn@456
PS1, Line 456: 			if (rx_rtp.msg.rtp.data != g_cfg.rx_fixed_payload) {
Since the rx_fixed_payload is optional I think we should check if it is present first. If it isn't we should never increment rx_fixed_payload.

So in ttcn3 speak I believe it should be:

if (g_cfg.rx_fixed_payload.is_present() && [..]) {


https://gerrit.osmocom.org/#/c/13000/1/library/RTP_Emulation.ttcn@457
PS1, Line 457: 				g_stats_rtp.num_pkts_rx_err_payload := g_stats_rtp.num_pkts_rx_err_payload + 1
missing semicolon
I know it's not required in TTCN3, but I think it's nicer to stay close to C syntax.



-- 
To view, visit https://gerrit.osmocom.org/13000
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b125aaf915497d0a4f051af890fc34e09da61d
Gerrit-Change-Number: 13000
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Feb 2019 13:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190222/bd9d5534/attachment.htm>