Change in libosmocore[master]: select: Call log_reset_context() before calling file descriptor callb...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Fri Feb 22 12:25:31 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/12998 )

Change subject: select: Call log_reset_context() before calling file descriptor callbacks
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/12998/1/src/select.c
File src/select.c:

https://gerrit.osmocom.org/#/c/12998/1/src/select.c@222
PS1, Line 222: 			log_reset_context();
> Probably doesn't change that much in practice, but I think it makes sense to remove it immeditelly A […]
Reading http://projects.osmocom.org/issues/3813 it seems that the log context can also be wrong in the first call of the for_each loop so just setting it after the callback would not help there.



-- 
To view, visit https://gerrit.osmocom.org/12998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3644c7bc1a9cec5858eb0faf94efc8c3ba7f5d8d
Gerrit-Change-Number: 12998
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Feb 2019 12:25:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190222/84d34b24/attachment.htm>


More information about the gerrit-log mailing list