Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Thu Feb 21 15:56:09 UTC 2019


tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Looks good to me except for the small cut&paste issue in the vty command.

https://gerrit.osmocom.org/#/c/12979/2/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/12979/2/src/libosmo-mgcp/mgcp_vty.c@743
PS2, Line 743: 	g_cfg->trunk.rfc5993_hr_convert = true;
I think this should be false.



-- 
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:56:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190221/4c3091c0/attachment.htm>


More information about the gerrit-log mailing list