Change in osmo-gsm-tester[master]: jenkins: Fix the test for journalctl if it isn't present

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Feb 21 14:52:47 UTC 2019


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12997 )

Change subject: jenkins: Fix the test for journalctl if it isn't present
......................................................................

jenkins: Fix the test for journalctl if it isn't present

test -x for an empty string is still true. Check if the result of
command is empty or not. It seems to work for the negative case now.

Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
---
M contrib/jenkins-run.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins-run.sh b/contrib/jenkins-run.sh
index 0b41247..4a76c09 100755
--- a/contrib/jenkins-run.sh
+++ b/contrib/jenkins-run.sh
@@ -30,7 +30,7 @@
 
 # tar up all results for archiving (optional)
 cd "$trial_dir"
-if [ -x $(command -v journalctl) ]; then
+if [ ! -z "$(command -v journalctl)" ]; then
   journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink last_run)/ofono.log"
 fi
 tar czf "$base/${trial_dir}-run.tgz" "$(readlink last_run)"

-- 
To view, visit https://gerrit.osmocom.org/12997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190221/06a8748e/attachment.htm>


More information about the gerrit-log mailing list