Change in osmo-bts[master]: oc2g: led_sleep_cb: pass correct ptr to llist_move_tail

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 20 20:39:49 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12965 )

Change subject: oc2g: led_sleep_cb: pass correct ptr to llist_move_tail
......................................................................

oc2g: led_sleep_cb: pass correct ptr to llist_move_tail

Fix compilation warning. At runtime it's not a big issue because the
"list" field is the first field of the led_list (struct
lc15bts_led_timer_list) variable. Hence, the address passed is the same.

Similar to commit fixing same issue in lc15 in 080302f8.

Change-Id: Ie393a21bc3a725520343c70941cb4f591b313420
---
M src/osmo-bts-oc2g/misc/oc2gbts_led.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_led.c b/src/osmo-bts-oc2g/misc/oc2gbts_led.c
index b8758b8..40d4b72 100644
--- a/src/osmo-bts-oc2g/misc/oc2gbts_led.c
+++ b/src/osmo-bts-oc2g/misc/oc2gbts_led.c
@@ -150,7 +150,7 @@
 			/* Delete current timer */
 			osmo_timer_del(&led_list->led_timer.timer);
 			/* Rotate the timer list */
-			 llist_move_tail(led_list, &mgr->oc2gbts_leds.list);
+			 llist_move_tail(&led_list->list, &mgr->oc2gbts_leds.list);
 			break;
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/12965
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie393a21bc3a725520343c70941cb4f591b313420
Gerrit-Change-Number: 12965
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190220/c970e854/attachment.htm>


More information about the gerrit-log mailing list