Change in osmo-bts[master]: OML: Store merged attributes of IPA OML Managed Objects

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 19 12:31:27 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12893 )

Change subject: OML: Store merged attributes of IPA OML Managed Objects
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12893/1/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/12893/1/src/common/oml.c@1337
PS1, Line 1337: 	tp_merged = osmo_tlvp_copy(mo->nm_attr, bts);
> Can this be moved inside 'success' branch of if()? In this case we won't have to free tp_merged and  […]
ACK



-- 
To view, visit https://gerrit.osmocom.org/12893
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75ebda46da9c1fcecc484311bf3833f31c536ee1
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Feb 2019 12:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190219/cab24522/attachment.htm>


More information about the gerrit-log mailing list