This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12947 ) Change subject: Add encoding tests for Immediate Assignment ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/12947/1/tests/types/TypesTest.cpp File tests/types/TypesTest.cpp: https://gerrit.osmocom.org/#/c/12947/1/tests/types/TypesTest.cpp@438 PS1, Line 438: struct msgb *m = msgb_alloc(80, "test"); I don't see this "m" being freed. https://gerrit.osmocom.org/#/c/12947/1/tests/types/TypesTest.cpp@458 PS1, Line 458: BTS the_bts; the_bts? lol why not "bts"? https://gerrit.osmocom.org/#/c/12947/1/tests/types/TypesTest.cpp@467 PS1, Line 467: check_imm_ass(tbf, true, GSM_L1_BURST_TYPE_ACCESS_2, res, ARRAY_SIZE(res)); I think it'd be more correct to use sizeof(res) here, since you are passing a length. Of course sizeof==ARRAY_SIZE in this case. -- To view, visit https://gerrit.osmocom.org/12947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63f4654b23c7c4f063f6b3254d77157fac798586 Gerrit-Change-Number: 12947 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 18 Feb 2019 21:25:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190218/c6884aed/attachment.htm>