Change in libosmocore[master]: gsm0808: comment about difference of gsm0808_create_clear_command()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 18 13:10:56 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12932 )

Change subject: gsm0808: comment about difference of gsm0808_create_clear_command()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12932/1/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/12932/1/src/gsm/gsm0808.c@181
PS1, Line 181: /*! Create BSSMAP Clear Command message with BSSAP header in l2h and BSSMAP in l3h.
> I don't see l2h being set here in this function. […]
thanks, indeed it wasn't l2h but simply before l3h without any l*h pointer pointing to it...



-- 
To view, visit https://gerrit.osmocom.org/12932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0367760a588fc968c5a2dea46001ef1ee7965c8c
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Feb 2019 13:10:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190218/853f0fba/attachment.htm>


More information about the gerrit-log mailing list