This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12869 ) Change subject: OML: Report short messages even for invalid TRX numbers in down_fom() ...................................................................... OML: Report short messages even for invalid TRX numbers in down_fom() Change-Id: I65b57d3fc714814db3ae3fd34398f307413fece8 --- M src/common/oml.c 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, but someone else must approve Max: Looks good to me, approved diff --git a/src/common/oml.c b/src/common/oml.c index ad8ab81..96d9dd6 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1093,12 +1093,10 @@ int ret; if (msgb_l2len(msg) < sizeof(*foh)) { - LOGP(DOML, LOGL_NOTICE, "Formatted O&M message too short\n"); trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr); - if (trx) { - oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MAJ_UKWN_MSG, - "Formatted O&M message too short"); - } + if (trx) + mo = &trx->mo; + oml_tx_failure_event_rep(mo, OSMO_EVT_MAJ_UKWN_MSG, "Formatted O&M message too short"); return -EIO; } -- To view, visit https://gerrit.osmocom.org/12869 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I65b57d3fc714814db3ae3fd34398f307413fece8 Gerrit-Change-Number: 12869 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190212/6e4eaf41/attachment.htm>