This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12867 ) Change subject: OML: send proper OML alerts in case of errors ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12867/2/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/12867/2/src/common/oml.c@1381 PS2, Line 1381: oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_MAJ_UKWN_MSG, > Without looking much around this code, one question: Why do you check for trx->mo existance and use […] if insufficient bytes of the header are present to resolve the MO (managed object) the message is addressed to, we can only use the BTS MO as a default. -- To view, visit https://gerrit.osmocom.org/12867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b19b82a4874617c7c584cf3eac55eb9c756710a Gerrit-Change-Number: 12867 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 12 Feb 2019 20:00:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190212/1e54ace0/attachment.htm>