Change in openbsc[master]: Make alert notifications vty configurable per ESME

[Keith Whyte]

Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12601 )

Change subject: Make alert notifications vty configurable per ESME
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12601/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:

https://gerrit.osmocom.org/#/c/12601/1/openbsc/src/libmsc/smpp_openbsc.c@291
PS1, Line 291: 		} else {
> (it's a pointer, so I assume you mean == NULL) […]
NULL,  false, yes well.. it's obvious i am not a C coder.

:(

I don't understand how it can be NULL, which is because I tried but failed to understand llist_for_each_entry()

Anyway, I guess the best thing is to try your suggesting to check osmo-acl, which I will do, only I'm on the road and a bit all over the place right now.
 
re: openbsc, this same bug exists in osmo-msc as the patch was the same.

I feel a bit demoralised now that I patched a crash causing bug in there :(((



-- 
To view, visit https://gerrit.osmocom.org/12601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b52f2778b24eebc82b2e5e2fb3c2250b1f9e5b0
Gerrit-Change-Number: 12601
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Feb 2019 01:22:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190212/93e04a2b/attachment.htm>