Change in osmo-bts[master]: OML: Properly reject short messages and truncate over-long messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Feb 10 17:06:05 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12873 )

Change subject: OML: Properly reject short messages and truncate over-long messages
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12873/1/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/12873/1/src/common/oml.c@1453
PS1, Line 1453: 		msgb_l3trim(msg, oh->length);
That's weird imho, I'd drop it with oml_tx_failure_event_rep(), since attempting decoding potentially corrupted message could end up in tragedy.



-- 
To view, visit https://gerrit.osmocom.org/12873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f0d7c2cff9172714ed18667c02564540d65d7
Gerrit-Change-Number: 12873
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 10 Feb 2019 17:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190210/a81adec4/attachment.htm>


More information about the gerrit-log mailing list