Change in osmo-bts[master]: OML: some more comments on what functions do

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 8 21:28:06 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/12862


Change subject: OML: some more comments on what functions do
......................................................................

OML: some more comments on what functions do

Change-Id: I5f30f6c556968fab60283ff1948966af28dc6e83
---
M src/common/oml.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/62/12862/1

diff --git a/src/common/oml.c b/src/common/oml.c
index 41debc1..ce59865 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -102,6 +102,7 @@
 	talloc_free(rep);
 }
 
+/* Push OM header in front of msgb and send it */
 int oml_send_msg(struct msgb *msg, int is_manuf)
 {
 	struct abis_om_hdr *omh;
@@ -363,6 +364,8 @@
 	return rc;
 }
 
+/* Send an ACK or NACK response from 'mo' to BSC, deriving message
+ * type from 'orig_msg_type'. ACK is sent if cause == 0; NACK otherwise */
 int oml_mo_fom_ack_nack(struct gsm_abis_mo *mo, uint8_t orig_msg_type,
 			uint8_t cause)
 {
@@ -417,6 +420,9 @@
 	return oml_mo_fom_ack_nack(mo, NM_MT_OPSTART, nack_cause);
 }
 
+/* Send an ACK or NACK response for 'msg' to BSC, deriving message
+ * type, obj class, obj inst from 'msg' and copying all attributes
+ * contained in 'msg'. ACK is sent if cause == 0; NACK otherwise */
 int oml_fom_ack_nack(struct msgb *old_msg, uint8_t cause)
 {
 	struct abis_om_hdr *old_oh = msgb_l2(old_msg);

-- 
To view, visit https://gerrit.osmocom.org/12862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f30f6c556968fab60283ff1948966af28dc6e83
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190208/395acaec/attachment.htm>


More information about the gerrit-log mailing list