Change in libosmocore[master]: GSUP: add inter-MSC handover related msgs and IEs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Feb 8 12:44:21 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/12860 )

Change subject: GSUP: add inter-MSC handover related msgs and IEs
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/12860/1/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/12860/1/include/osmocom/gsm/gsup.h@178
PS1, Line 178: 	OSMO_GSUP_MSGT_E_PREPARE_HANDOVER_REQUEST		= 0b001100100,
> These are all 9 bit long - typo? […]
Oh yes, made a typo the first time and then continued it. Fixed, thanks for finding this!


https://gerrit.osmocom.org/#/c/12860/1/src/gsm/gsup_handover.c
File src/gsm/gsup_handover.c:

https://gerrit.osmocom.org/#/c/12860/1/src/gsm/gsup_handover.c@2
PS1, Line 2:  * (C) 2019 by Oliver Smith <osmith at sysmocom.de>
> Last I heard copyright should be assigned like this: […]
Done


https://gerrit.osmocom.org/#/c/12860/1/src/gsm/gsup_handover.c@46
PS1, Line 46: 	/* Tag and total length */
> Should we check if there's enough space in msg before encoding? […]
Good point, fixed.



-- 
To view, visit https://gerrit.osmocom.org/12860
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic00b0601eacff6d72927cea51767801142ee75db
Gerrit-Change-Number: 12860
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Feb 2019 12:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190208/586b2fa6/attachment.htm>


More information about the gerrit-log mailing list