Change in osmo-sysmon[master]: Add OpenVPN probe

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Feb 7 17:29:06 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12763 )

Change subject: Add OpenVPN probe
......................................................................


Patch Set 7:

(5 comments)

https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_main.c
File src/osysmon_main.c:

https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_main.c@252
PS7, Line 252: 		sleep(1);
why not always polling osmocom event loop with a timeout of 1 second instead of instant polling + sleep?


https://gerrit.osmocom.org/#/c/12763/5/src/osysmon_openvpn.c
File src/osysmon_openvpn.c:

https://gerrit.osmocom.org/#/c/12763/5/src/osysmon_openvpn.c@263
PS5, Line 263: 
> What makes you think that? It should be automatically cleaned by talloc on vty refresh.
Why keeping it until then if it's not longer needed? Do we believe on garbage collectors now?


https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_openvpn.c
File src/osysmon_openvpn.c:

https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_openvpn.c@45
PS7, Line 45: 	fprintf(stderr, "OpenVPN [%s]: " fmt, make_authority(ctx, vpn->cfg), ##args)
make_authority memleaks here, or at least unnecesarily delays  its free.


https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_openvpn.c@67
PS7, Line 67: 	uint8_t *m = msgb_data(msg);
would be clearer to cast here already if we know it's a string:
char *m = (char*) msgb_data(msg);

then you can remove the cast in line 80.


https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_openvpn.c@104
PS7, Line 104: static struct openvpn_client *openvpn_client_find_or_make(const struct osysmon_state *os,
that's not making aything, its only finding.



-- 
To view, visit https://gerrit.osmocom.org/12763
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4493e19b9a09dcebd289457eacd1719f7f8cc31c
Gerrit-Change-Number: 12763
Gerrit-PatchSet: 7
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Feb 2019 17:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190207/9f550674/attachment.htm>


More information about the gerrit-log mailing list