This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12761 )
Change subject: Introduce generic host config and related helpers
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/12761/6/src/simple_ctrl.c
File src/simple_ctrl.c:
https://gerrit.osmocom.org/#/c/12761/6/src/simple_ctrl.c@42
PS6, Line 42: fprintf(stderr, "CTRL %s error: " fmt, make_authority(sch, &sch->cfg), ##args)
memleak of make_authority. At least until you free sch. I don't really like unnecesarily leaking stuff for a while for no good reason.
do {
foo = make_authority();
fprintf(... , foo);
talloc_free(foo);
} while(0);
--
To view, visit https://gerrit.osmocom.org/12761
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie321655a92cdbefbfaa056ac0d583397c83beccb
Gerrit-Change-Number: 12761
Gerrit-PatchSet: 6
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Feb 2019 17:19:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190207/aa0b18f7/attachment.htm>