This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12625 ) Change subject: assignment_fsm: fix channel allocator preferences ...................................................................... Patch Set 8: (1 comment) https://gerrit.osmocom.org/#/c/12625/8/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/12625/8/include/osmocom/bsc/gsm_data.h@104 PS8, Line 104: bool full_rate; > Just wondering if it wouldn't be worth directly using GSM_LCHAN_xxx constant in there rather than fu […] We ignore the MS channel preference on purpose and do "late assignment" instead. In osmo-nitb, we used to accept the TCH/F request from the MS and assign that, while on the MT side the CN's preference would be stronger, which could end up TCH/H (for dyn TS). Hence we would actively allow mismatching TCH kinds. Now, we always look at the MSC preferences during TCH/* Assignment. It is ok if we assign a TCH/F for SDCCH use at first, but it only really makes sense if there are no SDCCH left. We now do that. Recently there have been fixes for that behavior. So this channel_mode_and_rate is really only about TCH/F or TCH/H, no additional channel types should ever become relevant. Even if BTS has only TCH/H pchan configured, an MS will ask for TCH, F preferred. I'm not sure what's the benefit there, maybe that a phone already knows it is going to make a call and attempts to pre-empt the need to re-assign from SDCCH to TCH? It might make sense to revisit that once we properly support Channel Mode Modify commands and late RTP addition. Even then, the choice for SDCCH or TCH will happen before this code path; this here is for voice assignment. -- To view, visit https://gerrit.osmocom.org/12625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51 Gerrit-Change-Number: 12625 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: tnt <tnt at 246tNt.com> Gerrit-Comment-Date: Thu, 07 Feb 2019 16:05:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190207/238a7d38/attachment.htm>