Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
......................................................................


Patch Set 7:

(1 comment)

> I think this patch is missing to export the currently remaining timeout as part of the "show mgcp [stats]" command.  Or did I miss something?

Right, I did not think about displaying the remaining timeout anywhere. It is implemented now, e.g. with "conn-timeout 60":


 OsmoMGW> show mgcp stats                                                                 
 Virtual trunk 0 with 64 endpoints:                                                                  
 Virtual trunk 0 endpoint rtpbridge/01:                                                     
    CONN: (138c/rtp, id:0xC4E6CC99, ip:192.168.1.37, rtp:16008 rtcp:16009)                         
    Currently remaining timeout (seconds): 59.990917                                 
    Packets Sent: 108 (4955 bytes total)
    Packets Received: 108 (4955 bytes total)
 ...

And it even helped uncover a bug, I had parsed the conn-timeout value as hex number instead of decimal number. It's all fixed now, can you guys take another look?

https://gerrit.osmocom.org/#/c/12730/6/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/12730/6/src/libosmo-mgcp/mgcp_vty.c@1342
PS6, Line 1342: 
This must be 10!



-- 
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 06 Feb 2019 11:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190206/79b90104/attachment.htm>