Change in osmo-bsc[master]: handover_fsm: do not access conn->assignment.req, it may be outdated

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 6 00:31:48 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12734 )

Change subject: handover_fsm: do not access conn->assignment.req, it may be outdated
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> >conn->assignment.* values are only valid during an ongoing assignment
> 
> Maybe add clarifying comment next to them to make sure this mistake won't happen again?

ack, i've now added https://gerrit.osmocom.org/#/c/osmo-bsc/+/12842


-- 
To view, visit https://gerrit.osmocom.org/12734
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8018fd9d56421f2ab7be91703018f6d6f21c929
Gerrit-Change-Number: 12734
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Feb 2019 00:31:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190206/9de69bd9/attachment.htm>


More information about the gerrit-log mailing list