Change in libosmocore[master]: gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 5 15:11:36 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12829 )

Change subject: gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND
......................................................................

gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND

When a call that was established in a CSFB context ends the CLEAR
COMMAND that is send from the BSC to the MSC should contain a CSFB
indication IE, which consists of just the IE byte itsslef. This
additional IE tells the BSC to include other CSFB related IEs into the
RR Release message.

Change-Id: Id8a75e1da2d5f520064666e4ee413d1c91da6ae3
Related: OS#3778
---
M include/osmocom/gsm/gsm0808.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
3 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 6d14e13..35e7a8e 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -49,6 +49,7 @@
 struct msgb *gsm0808_create_reset(void);
 struct msgb *gsm0808_create_reset_ack(void);
 struct msgb *gsm0808_create_clear_command(uint8_t cause);
+struct msgb *gsm0808_create_clear_command2(uint8_t cause, bool csfb_ind);
 struct msgb *gsm0808_create_clear_complete(void);
 struct msgb *gsm0808_create_cipher(const struct gsm0808_encrypt_info *ei,
 				   const uint8_t *cipher_response_mode);
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index fce8e0a..2907255 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -195,6 +195,22 @@
 	return msg;
 }
 
+/*! Create BSSMAP Clear Command message.
+ *  \param[in] cause TS 08.08 cause value.
+ *  \param[in] csfb_ind indicate that the call was established in an CSFB context.
+ *  \returns callee-allocated msgb with BSSMAP Clear Command message. */
+struct msgb *gsm0808_create_clear_command2(uint8_t cause, bool csfb_ind)
+{
+	struct msgb *msg = gsm0808_create_clear_command(cause);
+	if (!msg)
+		return NULL;
+
+	if (csfb_ind)
+		msgb_v_put(msg, GSM0808_IE_CSFB_INDICATION);
+
+	return msg;
+}
+
 /*! Create BSSMAP Cipher Mode Command message
  *  \param[in] ei Mandatory Encryption Information
  *  \param[in] cipher_response_mode optional 1-byte Cipher Response Mode
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 3cfe6a7..602c7a6 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -164,6 +164,7 @@
 gsm0808_create_classmark_request;
 gsm0808_create_classmark_update;
 gsm0808_create_clear_command;
+gsm0808_create_clear_command2;
 gsm0808_create_clear_complete;
 gsm0808_create_clear_rqst;
 gsm0808_create_paging;

-- 
To view, visit https://gerrit.osmocom.org/12829
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8a75e1da2d5f520064666e4ee413d1c91da6ae3
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190205/06fc8a83/attachment.htm>


More information about the gerrit-log mailing list