Change in gr-gsm[master]: trx/radio_if.py: do not init both rx_freq and tx_freq

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Feb 5 11:33:08 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12632 )

Change subject: trx/radio_if.py: do not init both rx_freq and tx_freq
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12632/1/python/trx/radio_if.py
File python/trx/radio_if.py:

https://gerrit.osmocom.org/#/c/12632/1/python/trx/radio_if.py@230
PS1, Line 230: 			self.DUMMY_FREQ, phy_sample_rate, osr = self.osr)
> the DUMMY_FREQ is never changed. It should be updated in set_rx_freq. […]
Yep, agree with you. I've also noticed this, please see: https://gerrit.osmocom.org/#/c/gr-gsm/+/12637/



-- 
To view, visit https://gerrit.osmocom.org/12632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f251958ec90141d144fdb027aff20182131a1d1
Gerrit-Change-Number: 12632
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 11:33:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190205/c4a8be1d/attachment.htm>


More information about the gerrit-log mailing list