Change in libosmocore[master]: GSUP: deprecate osmo_gsup_get_err_msg_type()

[osmith]

Hello Vadim Yanitskiy, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/12777

to look at the new patch set (#2).

Change subject: GSUP: deprecate osmo_gsup_get_err_msg_type()
......................................................................

GSUP: deprecate osmo_gsup_get_err_msg_type()

Replace osmo_gsup_get_err_msg_type() with a wrapper to
OSMO_GSUP_TO_MSGT_ERROR(). This macro assumes, that all error messages
are (request message | 0x000001). Add a big comment header for
osmo_gsup_message_type, describing this already implicitly followed rule
and therefore making it explicit.

With this change, we don't need to maintain the request -> error message
mapping in osmo_gsup_get_err_msg_type() anymore.

Related: Iec1b4ce4b7d8eb157406f006e1c4241e8fba2cd6 (osmo-gsm-manuals)
Change-Id: I46d9f2327791978710e2f90b4d28a3761d723d8f
---
M include/osmocom/gsm/gsup.h
M src/gsm/gsup.c
2 files changed, 17 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/12777/2
-- 
To view, visit https://gerrit.osmocom.org/12777
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46d9f2327791978710e2f90b4d28a3761d723d8f
Gerrit-Change-Number: 12777
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190204/b2e44fe4/attachment.htm>