This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/12779 ) Change subject: scheduler_trx: use stored block fn instead of calculating it. ...................................................................... Patch Set 1: (1 comment) The first *first_fn pointer points to chan_state->ul_first_fn. I was assuming that this is per channel and that the fn of the first received burst is recoreded and so it sounded logical to to me that this is the FN of the complete block that is then handed upwards to the higher layers, even when the block is spread over non consecutive bursts. We still have the fn where the block has begun. What I find confusing is that at the moment we use different fn for the measurement indications and for the TCH/DATA indications. To me this sounds incorrect. From my understanding, the measurement indication should have the same fn as the TCH/DATA indication. At the moment I am trying to merge TCH/DATA and measurement inidcation so that they are a single object that is handed upwards. It would be important to know that if we we would end up with two different types of FN in that unified indication or not. Assuming everything is calculated correctly, would end up with a single FN? We need to solve this somehow, otherwise it will not be possible to merge TCH/DATA indication with the measurement indication cleanly. https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c@1306 PS1, Line 1306: printf > Left from debugging? ;) Done -- To view, visit https://gerrit.osmocom.org/12779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia27254bbf6e36426f7890ece6154dcd395673f63 Gerrit-Change-Number: 12779 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Comment-Date: Mon, 04 Feb 2019 10:04:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190204/745c7da0/attachment.htm>