Change in osmo-gsm-manuals[master]: GSUP: message category indicated by last two bits

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Feb 4 09:56:38 UTC 2019


osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/12778 )

Change subject: GSUP: message category indicated by last two bits
......................................................................

GSUP: message category indicated by last two bits

Make this part of the specification, so we can simplify libosmocore
code by knowing that error message is (request message | 0x000001).

Related: I46d9f2327791978710e2f90b4d28a3761d723d8f (libosmocore)
Change-Id: Iec1b4ce4b7d8eb157406f006e1c4241e8fba2cd6
---
M common/chapters/gsup.adoc
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Max: Looks good to me, approved



diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc
index 673ed59..7a16e64 100644
--- a/common/chapters/gsup.adoc
+++ b/common/chapters/gsup.adoc
@@ -766,6 +766,19 @@
 |0x32|CHECK-IMEI Result
 |===
 
+The category of the message is indicated by the last two bits of the type.
+Request, Error and Result messages only differ in these last two bits, so it is
+trivial to transform them.
+
+[options="header",cols="20%,80%"]
+|===
+|Ending Bits|Message Category
+|00|Request
+|01|Error
+|10|Result
+|11|Other
+|===
+
 [[gsup-ie-ipaddr]]
 ==== IP Address
 

-- 
To view, visit https://gerrit.osmocom.org/12778
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec1b4ce4b7d8eb157406f006e1c4241e8fba2cd6
Gerrit-Change-Number: 12778
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190204/93190b53/attachment.htm>


More information about the gerrit-log mailing list