Change in libosmo-netif[master]: Stream client: fix disconnection logic

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Feb 4 09:14:24 UTC 2019


Hello daniel, osmith, Jenkins Builder, Pablo Neira Ayuso, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/12760

to look at the new patch set (#2).

Change subject: Stream client: fix disconnection logic
......................................................................

Stream client: fix disconnection logic

Previously closing the client did not alter its state, so we might
end-up with a client without any file descriptors, but being in state
STREAM_CLI_STATE_CONNECTED. Fix this inconsistency by setting
appropriate state.

Related issue is that reconnect function, which is always (at least in
the library and examples) called when some problem with the connection
is detected, closed the connection only after checking whether
reconnection is enabled. This might result in another inconsistency
fixed in this patch by moving the check below connection cleanup.

Change-Id: If41ed60bd625488c283d1e8a2b078e640f04c78e
---
M src/stream.c
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/60/12760/2
-- 
To view, visit https://gerrit.osmocom.org/12760
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If41ed60bd625488c283d1e8a2b078e640f04c78e
Gerrit-Change-Number: 12760
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190204/5c8efbb8/attachment.htm>


More information about the gerrit-log mailing list