Change in libosmocore[master]: add generic vty_transcript_test.c, vty_transcript_test.vty

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Feb 1 18:35:08 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12768 )

Change subject: add generic vty_transcript_test.c, vty_transcript_test.vty
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12768/1/tests/Makefile.am
File tests/Makefile.am:

https://gerrit.osmocom.org/#/c/12768/1/tests/Makefile.am@339
PS1, Line 339: $(srcdir)/vty/*.vty
I think you need to add *.vty to EXTRA_DIST.


https://gerrit.osmocom.org/#/c/12768/1/tests/vty/vty_transcript_test.c
File tests/vty/vty_transcript_test.c:

https://gerrit.osmocom.org/#/c/12768/1/tests/vty/vty_transcript_test.c@132
PS1, Line 132: 		 * and then return to the caller, who will abort the process */
Please add some 'fall-through' label.



-- 
To view, visit https://gerrit.osmocom.org/12768
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a79c83fabd02aba6406b6e0d620969c4bd0cc1d
Gerrit-Change-Number: 12768
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 01 Feb 2019 18:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190201/905f6242/attachment.htm>


More information about the gerrit-log mailing list