This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16661 ) Change subject: l1sap: is_fille_frame(): assert len of data compared ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/16661/1/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/16661/1/src/common/l1sap.c@463 PS1, Line 463: OSMO_ASSERT(len == GSM_MACBLOCK_LEN); > wouldn't it be safer to simlpy return false if the length is not what we expect? Aren't there situa […] zero length frame is checked in a condition before calling this function, but I can change it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3d1725ff36091ed5c57927caad09a8baea6f52e Gerrit-Change-Number: 16661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 23 Dec 2019 17:26:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191223/1040d9c9/attachment.htm>