This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649 )
Change subject: BTS_Tests: tolerate empty measurement result on chan est.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
putting -1 related my comment as there are already two +1.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/2/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/2/bts/BTS_Tests.ttcn@1788
PS2, Line 1788: [] RSL.receive(f_build_meas_res_tmpl_empty()) -> value rsl {
how are we guarding this to prevent a situation where the MS is sending many empty measurement reports, even at a later time? shouldn't there be some kind of non-empty guard ([]) here ensuring that this clause can only be executed for the beginning (g_next_meas_res_nr < FOO) or so?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f511991349ab15e02db9c5e45f0df3645835a4
Gerrit-Change-Number: 16649
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Dec 2019 17:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191223/4d839d39/attachment.htm>