Change in osmo-pcu[master]: Pass paging group instead of imsi where later is not needed

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Dec 23 17:08:47 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16672 )

Change subject: Pass paging group instead of imsi where later is not needed
......................................................................


Patch Set 1:

it's a bit weird to me that we neither pass a NUL-terminated string, nor do we simply pass an integer.  The paging group is an integer in the range 0..999 which is computed from the three final digits of the IMSI.

Yes, it can be done this way, but I think it's not very elegant, and easy to introdcue errors if you're passing arrays of characters without zero-termination.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16672
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id0663a81f439f2d0b893b0d34f85a6db1927ef8e
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 23 Dec 2019 17:08:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191223/db9c9bf2/attachment.htm>


More information about the gerrit-log mailing list