Change in osmo-bts[master]: l1sap: is_fille_frame(): assert len of data compared

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Dec 20 15:36:32 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16661 )


Change subject: l1sap: is_fille_frame(): assert len of data compared
......................................................................

l1sap: is_fille_frame(): assert len of data compared

Change-Id: Id3d1725ff36091ed5c57927caad09a8baea6f52e
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/16661/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 213099d..d8848c2 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -460,10 +460,12 @@
 {
 	switch (chan_type) {
 	case GSMTAP_CHANNEL_AGCH:
+		OSMO_ASSERT(len == GSM_MACBLOCK_LEN);
 		if (!memcmp(data, fill_frame, GSM_MACBLOCK_LEN))
 			return true;
 		break;
 	case GSMTAP_CHANNEL_PCH:
+		OSMO_ASSERT(len == GSM_MACBLOCK_LEN);
 		if (!memcmp(data, paging_fill, GSM_MACBLOCK_LEN))
 			return true;
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id3d1725ff36091ed5c57927caad09a8baea6f52e
Gerrit-Change-Number: 16661
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191220/9781581d/attachment.htm>


More information about the gerrit-log mailing list