Change in libosmo-sccp[master]: ASP: Stop re-transmitting un-acknowledged messages on SCTP down event

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15977 )

Change subject: ASP: Stop re-transmitting un-acknowledged messages on SCTP down event
......................................................................

ASP: Stop re-transmitting un-acknowledged messages on SCTP down event

We don't want to attempt to re-transmit if we lost the connection:

DLSS7 <000c> xua_asp_fsm.c:251 XUA_ASP(asp-client0){ASP_DOWN}: T(ack) callback: re-transmitting event ASPSM-ASP_UP
DLSS7 <000c> osmo_ss7.c:1833 0: asp-asp-client0: Cannot transmit, asp->client not connected
DLSS7 <000c> xua_asp_fsm.c:251 XUA_ASP(asp-client0){ASP_DOWN}: T(ack) callback: re-transmitting event ASPSM-ASP_UP
DLSS7 <000c> osmo_ss7.c:1833 0: asp-asp-client0: Cannot transmit, asp->client not connected
DLSS7 <000c> xua_asp_fsm.c:251 XUA_ASP(asp-client0){ASP_DOWN}: T(ack) callback: re-transmitting event ASPSM-ASP_UP
DLSS7 <000c> osmo_ss7.c:1833 0: asp-asp-client0: Cannot transmit, asp->client not connected
DLSS7 <000c> xua_asp_fsm.c:251 XUA_ASP(asp-client0){ASP_DOWN}: T(ack) callback: re-transmitting event ASPSM-ASP_UP
DLSS7 <000c> osmo_ss7.c:1833 0: asp-asp-client0: Cannot transmit, asp->client not connected
DLSS7 <000c> xua_asp_fsm.c:251 XUA_ASP(asp-client0){ASP_DOWN}: T(ack) callback: re-transmitting event ASPSM-ASP_UP

Change-Id: Ic8da646d22d3120121d9af43a890762a879f9d74
---
M src/xua_asp_fsm.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 2fe2c8a..64892ad 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -663,11 +663,13 @@
 
 static void xua_asp_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
+	struct xua_asp_fsm_priv *xafp = fi->priv;
 	struct xua_msg *xua;
 
 	switch (event) {
 	case XUA_ASP_E_SCTP_COMM_DOWN_IND:
 	case XUA_ASP_E_SCTP_RESTART_IND:
+		osmo_timer_del(&xafp->t_ack.timer);
 		osmo_fsm_inst_state_chg(fi, XUA_ASP_S_DOWN, 0, 0);
 		send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_DOWN,
 				     PRIM_OP_INDICATION);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15977
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic8da646d22d3120121d9af43a890762a879f9d74
Gerrit-Change-Number: 15977
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/e952907d/attachment.htm>