Change in libosmo-sccp[master]: ASP: Stop re-transmitting un-acknowledged messages on SCTP down event

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 17 14:01:41 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15977 )

Change subject: ASP: Stop re-transmitting un-acknowledged messages on SCTP down event
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-sccp/+/15977/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15977/3//COMMIT_MSG@9 
PS3, Line 9: We don't want to attempt to re-transimt if we lots the connection:
> If we have lots of connections it's fine re-transimting! […]
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/15977/3/src/xua_asp_fsm.c 
File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15977/3/src/xua_asp_fsm.c@605 
PS3, Line 605: 		osmo_timer_del(&xafp->t_ack.timer);
> will the timer be armed again when we re-gain connectivity? or are we simply dropping everything on  […]
which queue are you referring to?  This timer has no queue associated with it, it is simply storing the message type of  the last to-be-acknowledged message we sent, so we know what to re-transmit in case it wasn't ACKed by the peer.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15977
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic8da646d22d3120121d9af43a890762a879f9d74
Gerrit-Change-Number: 15977
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Dec 2019 14:01:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/8a703da7/attachment.htm>


More information about the gerrit-log mailing list