This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16643 )
Change subject: osmo-depcheck: Skip comment lines containing PKG_CHECK_CONFIG
......................................................................
osmo-depcheck: Skip comment lines containing PKG_CHECK_CONFIG
This is a problem e.g. with current osmo-hlr containing
"\t# FIXME: PKG_CHECK_MODULES() may return cached result here!"
Change-Id: I30d539a895bf39aaabe907be9eb52d7e4b3977a7
---
M scripts/osmo-depcheck/parse.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
laforge: Verified
diff --git a/scripts/osmo-depcheck/parse.py b/scripts/osmo-depcheck/parse.py
index 06f932e..e9914f8 100644
--- a/scripts/osmo-depcheck/parse.py
+++ b/scripts/osmo-depcheck/parse.py
@@ -3,6 +3,7 @@
import sys
import fnmatch
+import re
# Same folder
import config
@@ -53,6 +54,8 @@
# Only look at PKG_CHECK_MODULES lines
if "PKG_CHECK_MODULES" not in line:
return
+ if re.search('#.*PKG_CHECK_MODULES', line):
+ return
# Extract the condition
ret = line.split(",")[1].split(")")[0].strip()
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/16643
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I30d539a895bf39aaabe907be9eb52d7e4b3977a7
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/57ca413b/attachment.htm>