This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16635 ) Change subject: simtrace2-sniff: Reformat value_string to pass our validation scripts ...................................................................... simtrace2-sniff: Reformat value_string to pass our validation scripts This is a purely cosmetic change in terms of coding style, but it fixes an [invalid] detection for unterminated value_string arrays by our verify_value_string_arrays_are_terminated.py script: Change-Id: Iee905c744065df1dc54f04be752a65700897a92c ERROR: file contains unterminated value_string 'struct value_string change_flags[]': './deps/simtrace2/host/src/simtrace2-sniff.c' ERROR: file contains unterminated value_string 'struct value_string data_flags[]': './deps/simtrace2/host/src/simtrace2-sniff.c' --- M host/src/simtrace2-sniff.c 1 file changed, 10 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/35/16635/1 diff --git a/host/src/simtrace2-sniff.c b/host/src/simtrace2-sniff.c index b2ce4a0..c4cec1e 100644 --- a/host/src/simtrace2-sniff.c +++ b/host/src/simtrace2-sniff.c @@ -61,49 +61,19 @@ }; const struct value_string change_flags[] = { - { - .value = SNIFF_CHANGE_FLAG_CARD_INSERT, - .str = "card inserted", - }, - { - .value = SNIFF_CHANGE_FLAG_CARD_EJECT, - .str = "card ejected", - }, - { - .value = SNIFF_CHANGE_FLAG_RESET_ASSERT, - .str = "reset asserted", - }, - { - .value = SNIFF_CHANGE_FLAG_RESET_DEASSERT, - .str = "reset de-asserted", - }, - { - .value = SNIFF_CHANGE_FLAG_TIMEOUT_WT, - .str = "data transfer timeout", - }, - { - .value = 0, - .str = NULL, - }, + { SNIFF_CHANGE_FLAG_CARD_INSERT, "card inserted" }, + { SNIFF_CHANGE_FLAG_CARD_EJECT, "card ejected" }, + { SNIFF_CHANGE_FLAG_RESET_ASSERT, "reset asserted" }, + { SNIFF_CHANGE_FLAG_RESET_DEASSERT, "reset de-asserted" }, + { SNIFF_CHANGE_FLAG_TIMEOUT_WT, "data transfer timeout" }, + { 0, NULL } }; const struct value_string data_flags[] = { - { - .value = SNIFF_DATA_FLAG_ERROR_INCOMPLETE, - .str = "incomplete", - }, - { - .value = SNIFF_DATA_FLAG_ERROR_MALFORMED, - .str = "malformed", - }, - { - .value = SNIFF_DATA_FLAG_ERROR_CHECKSUM, - .str = "checksum error", - }, - { - .value = 0, - .str = NULL, - }, + { SNIFF_DATA_FLAG_ERROR_INCOMPLETE, "incomplete" }, + { SNIFF_DATA_FLAG_ERROR_MALFORMED, "malformed" }, + { SNIFF_DATA_FLAG_ERROR_CHECKSUM, "checksum error" }, + { 0, NULL } }; static void print_flags(const struct value_string* flag_meanings, uint32_t nb_flags, uint32_t flags) { -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Iee905c744065df1dc54f04be752a65700897a92c Gerrit-Change-Number: 16635 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/d56ed4e8/attachment.htm>