This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/16499 )
Change subject: rspro_client_fsm: Disable automatic connect on FSM allocation
......................................................................
rspro_client_fsm: Disable automatic connect on FSM allocation
So far, the rspor_client_fsm immediately attempted to establish a
TCP connection to the RSPRO server when calling server_conn_fsm_alloc().
Let's make this implicit auto-connect an explicit request to connect
using the newly-introduced SRVC_E_ESTABLISH.
Let's also change all three existing users of server_conn_fsm_alloc()
to send SRVC_E_ESTABLISH after calling it.
The rationale of this change is to use the same rspro_client_fsm also
for the client->bankd RSPRO connection, where we don't want to
automatically connect at startup, but connect only at a later point, after the
server a has told us to do so.
Change-Id: Icd882405f2ef54e10a66054829c089e4985f1d1f
---
M src/bankd/bankd_main.c
M src/remsim_client.c
M src/rspro_client_fsm.c
M src/rspro_client_fsm.h
M src/simtrace2-remsim_client.c
5 files changed, 52 insertions(+), 51 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c
index a204be5..194baef 100644
--- a/src/bankd/bankd_main.c
+++ b/src/bankd/bankd_main.c
@@ -363,6 +363,7 @@
fprintf(stderr, "Unable to create Server conn FSM: %s\n", strerror(errno));
exit(1);
}
+ osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_ESTABLISH, NULL);
/* create listening socket for inbound client connections */
rc = osmo_sock_init(AF_INET, SOCK_STREAM, IPPROTO_TCP, g_bind_ip, g_bind_port, OSMO_SOCK_F_BIND);
diff --git a/src/remsim_client.c b/src/remsim_client.c
index 0bfc0a4..ca6143e 100644
--- a/src/remsim_client.c
+++ b/src/remsim_client.c
@@ -255,6 +255,7 @@
fprintf(stderr, "Unable to create Server conn FSM: %s\n", strerror(errno));
exit(1);
}
+ osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_ESTABLISH, NULL);
asn_debug = 0;
diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index 7045778..9f2d7c0 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -100,6 +100,7 @@
};
static const struct value_string server_conn_fsm_event_names[] = {
+ OSMO_VALUE_STRING(SRVC_E_ESTABLISH),
OSMO_VALUE_STRING(SRVC_E_TCP_UP),
OSMO_VALUE_STRING(SRVC_E_TCP_DOWN),
OSMO_VALUE_STRING(SRVC_E_KA_TIMEOUT),
@@ -180,52 +181,10 @@
.wait_for_resp = 10,
};
-static void srvc_st_init_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state)
-{
- struct rspro_server_conn *srvc = (struct rspro_server_conn *) fi->priv;
- int rc;
-
- srvc->conn = ipa_client_conn_create(fi, NULL, 0, srvc->server_host, srvc->server_port,
- srvc_updown_cb, srvc_read_cb, NULL, srvc);
- if (!srvc->conn) {
- LOGPFSM(fi, "Unable to create socket: %s\n", strerror(errno));
- goto out_fi;
- }
-
- srvc->keepalive_fi = ipa_client_conn_alloc_keepalive_fsm(srvc->conn, &ka_params, fi->id);
- if (!srvc->keepalive_fi) {
- LOGPFSM(fi, "Unable to create keepalive FSM\n");
- goto out_conn;
- }
- /* ensure parent is notified once keepalive FSM instance is dying */
- osmo_fsm_inst_change_parent(srvc->keepalive_fi, srvc->fi, SRVC_E_KA_TIMEOUT);
-
- /* Attempt to connect TCP socket */
- rc = ipa_client_conn_open(srvc->conn);
- if (rc < 0) {
- LOGPFSML(fi, LOGL_NOTICE, "Unable to connect: %s\n", strerror(errno));
- goto out_ka;
- }
-
- return;
-
-out_ka:
- osmo_fsm_inst_term(srvc->keepalive_fi, OSMO_FSM_TERM_ERROR, NULL);
-out_conn:
- ipa_client_conn_destroy(srvc->conn);
-out_fi:
- osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL);
-}
-
static void srvc_st_init(struct osmo_fsm_inst *fi, uint32_t event, void *data)
{
switch (event) {
- case SRVC_E_TCP_UP:
- osmo_fsm_inst_state_chg(fi, SRVC_ST_ESTABLISHED, T1_WAIT_CLIENT_CONN_RES, 1);
- break;
- case SRVC_E_TCP_DOWN:
- osmo_fsm_inst_state_chg(fi, SRVC_ST_REESTABLISH, T2_RECONNECT, 2);
- break;
+ case SRVC_E_ESTABLISH:
default:
OSMO_ASSERT(0);
}
@@ -290,12 +249,39 @@
struct rspro_server_conn *srvc = (struct rspro_server_conn *) fi->priv;
int rc;
- ipa_keepalive_fsm_stop(srvc->keepalive_fi);
+ if (srvc->keepalive_fi) {
+ ipa_keepalive_fsm_stop(srvc->keepalive_fi);
+ osmo_fsm_inst_term(srvc->keepalive_fi, OSMO_FSM_TERM_REGULAR, NULL);
+ srvc->keepalive_fi = NULL;
+ }
+
+ if (srvc->conn) {
+ LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n");
+ ipa_client_conn_close(srvc->conn);
+ ipa_client_conn_destroy(srvc->conn);
+ srvc->conn = NULL;
+ }
+ LOGPFSML(fi, LOGL_INFO, "Creating TCP connection to server at %s:%u\n",
+ srvc->server_host, srvc->server_port);
+ srvc->conn = ipa_client_conn_create(fi, NULL, 0, srvc->server_host, srvc->server_port,
+ srvc_updown_cb, srvc_read_cb, NULL, srvc);
+ if (!srvc->conn) {
+ LOGPFSML(fi, LOGL_FATAL, "Unable to create socket: %s\n", strerror(errno));
+ exit(1);
+ }
+
+ srvc->keepalive_fi = ipa_client_conn_alloc_keepalive_fsm(srvc->conn, &ka_params, fi->id);
+ if (!srvc->keepalive_fi) {
+ LOGPFSM(fi, "Unable to create keepalive FSM\n");
+ exit(1);
+ }
+ /* ensure parent is notified once keepalive FSM instance is dying */
+ osmo_fsm_inst_change_parent(srvc->keepalive_fi, srvc->fi, SRVC_E_KA_TIMEOUT);
/* Attempt to connect TCP socket */
rc = ipa_client_conn_open(srvc->conn);
if (rc < 0) {
- LOGPFSM(fi, "Unable to connect RSPRO to %s:%d - %s\n",
+ LOGPFSML(fi, LOGL_FATAL, "Unable to connect RSPRO to %s:%u - %s\n",
srvc->server_host, srvc->server_port, strerror(errno));
/* FIXME: retry? Timer? Abort? */
OSMO_ASSERT(0);
@@ -316,16 +302,28 @@
}
}
+static void srvc_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data)
+{
+ switch (event) {
+ case SRVC_E_ESTABLISH:
+ osmo_fsm_inst_state_chg(fi, SRVC_ST_REESTABLISH, T2_RECONNECT, 2);
+ break;
+ default:
+ OSMO_ASSERT(0);
+ }
+}
+
static int server_conn_fsm_timer_cb(struct osmo_fsm_inst *fi)
{
struct rspro_server_conn *srvc = (struct rspro_server_conn *) fi->priv;
switch (fi->T) {
case 2:
+ /* TCP reconnect failed: retry */
osmo_fsm_inst_state_chg(fi, SRVC_ST_REESTABLISH, T2_RECONNECT, 2);
break;
case 1:
- /* close connection and re-start connection attempt */
+ /* no ClientConnectRes received: disconnect + reconnect */
ipa_client_conn_close(srvc->conn);
osmo_fsm_inst_dispatch(fi, SRVC_E_TCP_DOWN, NULL);
break;
@@ -339,10 +337,9 @@
static const struct osmo_fsm_state server_conn_fsm_states[] = {
[SRVC_ST_INIT] = {
.name = "INIT",
- .in_event_mask = S(SRVC_E_TCP_UP) | S(SRVC_E_TCP_DOWN),
- .out_state_mask = S(SRVC_ST_ESTABLISHED) | S(SRVC_ST_REESTABLISH),
+ .in_event_mask = 0, /* S(SRVC_E_ESTABLISH) via allstate */
+ .out_state_mask = S(SRVC_ST_REESTABLISH),
.action = srvc_st_init,
- .onenter = srvc_st_init_onenter,
},
[SRVC_ST_ESTABLISHED] = {
.name = "ESTABLISHED",
@@ -370,6 +367,8 @@
.name = "RSPRO_CLIENT",
.states = server_conn_fsm_states,
.num_states = ARRAY_SIZE(server_conn_fsm_states),
+ .allstate_event_mask = S(SRVC_E_ESTABLISH),
+ .allstate_action = srvc_allstate_action,
.timer_cb = server_conn_fsm_timer_cb,
.log_subsys = DMAIN,
.event_names = server_conn_fsm_event_names,
@@ -384,8 +383,6 @@
return -1;
srvc->fi = fi;
- /* onenter of the initial state is not automatically executed by osmo_fsm :( */
- srvc_st_init_onenter(fi, 0);
return 0;
}
diff --git a/src/rspro_client_fsm.h b/src/rspro_client_fsm.h
index 8e7f58c..c11e260 100644
--- a/src/rspro_client_fsm.h
+++ b/src/rspro_client_fsm.h
@@ -5,6 +5,7 @@
#include <osmocom/rspro/RsproPDU.h>
enum server_conn_fsm_event {
+ SRVC_E_ESTABLISH, /* instruct SRVC to (re)etablish TCP connection to bankd */
SRVC_E_TCP_UP,
SRVC_E_TCP_DOWN,
SRVC_E_KA_TIMEOUT,
diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c
index 69d6a04..19f84a3 100644
--- a/src/simtrace2-remsim_client.c
+++ b/src/simtrace2-remsim_client.c
@@ -868,6 +868,7 @@
fprintf(stderr, "Unable to create Server conn FSM: %s\n", strerror(errno));
exit(1);
}
+ osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_ESTABLISH, NULL);
asn_debug = 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/16499
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Icd882405f2ef54e10a66054829c089e4985f1d1f
Gerrit-Change-Number: 16499
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191214/ef7b767b/attachment.htm>