This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16572 ) Change subject: Add missing CR to achieve CRLF at end of log lines ...................................................................... Add missing CR to achieve CRLF at end of log lines Change-Id: Ic4afb2981f68811fddb272e64dbddd3397a12642 --- M firmware/libcommon/source/cciddriver.c M firmware/libcommon/source/host_communication.c M firmware/libcommon/source/simtrace_iso7816.c 3 files changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/libcommon/source/cciddriver.c b/firmware/libcommon/source/cciddriver.c index 1dbdf23..dfadd6b 100644 --- a/firmware/libcommon/source/cciddriver.c +++ b/firmware/libcommon/source/cciddriver.c @@ -428,7 +428,7 @@ uint16_t msglen = 0; uint32_t ret; - TRACE_DEBUG("PCtoRDRXfrBlock\n"); + TRACE_DEBUG("PCtoRDRXfrBlock\n\r"); // Check the block length if ( ccidDriver.sCcidCommand.wLength > (configurationDescriptorsFS->ccid.dwMaxCCIDMessageLength-10) ) { @@ -921,7 +921,7 @@ void CCID_SmartCardRequest( void ) { unsigned char bStatus; - TRACE_DEBUG("CCID_req\n"); + TRACE_DEBUG("CCID_req\n\r"); do { diff --git a/firmware/libcommon/source/host_communication.c b/firmware/libcommon/source/host_communication.c index c305b80..d500aed 100644 --- a/firmware/libcommon/source/host_communication.c +++ b/firmware/libcommon/source/host_communication.c @@ -40,10 +40,10 @@ local_irq_save(x); bep->in_progress--; local_irq_restore(x); - TRACE_DEBUG("%u: in_progress=%lu\n", bep->ep, bep->in_progress); + TRACE_DEBUG("%u: in_progress=%lu\r\n", bep->ep, bep->in_progress); if (status != USBD_STATUS_SUCCESS) - TRACE_ERROR("%s error, status=%d\n", __func__, status); + TRACE_ERROR("%s error, status=%d\r\n", __func__, status); usb_buf_free(msg); } @@ -86,13 +86,13 @@ rc = USBD_Write(ep, msgb_data(msg), msgb_length(msg), (TransferCallback) &usb_write_cb, msg); if (rc != USBD_STATUS_SUCCESS) { - TRACE_ERROR("%s error %x\n", __func__, rc); + TRACE_ERROR("%s error %x\r\n", __func__, rc); /* re-insert to head of queue */ llist_add_irqsafe(&msg->list, &bep->queue); local_irq_save(x); bep->in_progress--; local_irq_restore(x); - TRACE_DEBUG("%02x: in_progress=%lu\n", bep->ep, bep->in_progress); + TRACE_DEBUG("%02x: in_progress=%lu\r\n", bep->ep, bep->in_progress); return 0; } @@ -112,7 +112,7 @@ bep->in_progress = 0; if (status != USBD_STATUS_SUCCESS) { - TRACE_ERROR("%s error, status=%d\n", __func__, status); + TRACE_ERROR("%s error, status=%d\r\n", __func__, status); usb_buf_free(msg); return; } @@ -150,7 +150,7 @@ rc = USBD_Read(ep, msg->head, msgb_tailroom(msg), (TransferCallback) &usb_read_cb, msg); if (rc != USBD_STATUS_SUCCESS) { - TRACE_ERROR("%s error %d\n", __func__, rc); + TRACE_ERROR("%s error %d\r\n", __func__, rc); usb_buf_free(msg); bep->in_progress = 0; } diff --git a/firmware/libcommon/source/simtrace_iso7816.c b/firmware/libcommon/source/simtrace_iso7816.c index dc41c08..8742696 100644 --- a/firmware/libcommon/source/simtrace_iso7816.c +++ b/firmware/libcommon/source/simtrace_iso7816.c @@ -71,7 +71,7 @@ USBD_Write(SIMTRACE_USB_EP_PHONE_INT, "R", 1, (TransferCallback) & Callback_PhoneRST_ISR, 0)) != USBD_STATUS_SUCCESS) { - TRACE_ERROR("USB err status: %d (%s)\n", ret, __FUNCTION__); + TRACE_ERROR("USB err status: %d (%s)\r\n", ret, __FUNCTION__); return; } @@ -109,7 +109,7 @@ /* Fill char into buffer */ rbuf_write(&sim_rcv_buf, c); } else { - TRACE_DEBUG("e %x st: %lx\n", c, stat); + TRACE_DEBUG("e %x st: %lx\r\n", c, stat); } /* else: error occurred */ char_stat = stat; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ic4afb2981f68811fddb272e64dbddd3397a12642 Gerrit-Change-Number: 16572 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191214/8aef6e9e/attachment.htm>