This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16570 ) Change subject: Fix format string related warnings (int vs. long) ...................................................................... Fix format string related warnings (int vs. long) Change-Id: I924a16f03e2a099b9f8eb56746bff2b9101c6802 --- M firmware/atmel_softpack_libraries/libchip_sam3s/source/efc.c M firmware/atmel_softpack_libraries/libchip_sam3s/source/flashd.c M firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c M firmware/libcommon/source/host_communication.c M firmware/libcommon/source/simtrace_iso7816.c 5 files changed, 8 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/atmel_softpack_libraries/libchip_sam3s/source/efc.c b/firmware/atmel_softpack_libraries/libchip_sam3s/source/efc.c index 0c288e0..f8925b4 100644 --- a/firmware/atmel_softpack_libraries/libchip_sam3s/source/efc.c +++ b/firmware/atmel_softpack_libraries/libchip_sam3s/source/efc.c @@ -163,7 +163,7 @@ wPage = (dwAddress - IFLASH_ADDR) / IFLASH_PAGE_SIZE; wOffset = (dwAddress - IFLASH_ADDR) % IFLASH_PAGE_SIZE; - TRACE_DEBUG( "Translated 0x%08X to page=%d and offset=%d\n\r", dwAddress, wPage, wOffset ) ; + TRACE_DEBUG( "Translated 0x%08lX to page=%d and offset=%d\n\r", dwAddress, wPage, wOffset ) ; /* Store values */ if ( pEfc ) { diff --git a/firmware/atmel_softpack_libraries/libchip_sam3s/source/flashd.c b/firmware/atmel_softpack_libraries/libchip_sam3s/source/flashd.c index 677ea30..c661b3f 100644 --- a/firmware/atmel_softpack_libraries/libchip_sam3s/source/flashd.c +++ b/firmware/atmel_softpack_libraries/libchip_sam3s/source/flashd.c @@ -134,7 +134,7 @@ // Store actual page numbers EFC_ComputeAddress( pStartEfc, wActualStartPage, 0, pdwActualStart ) ; EFC_ComputeAddress( pEndEfc, wActualEndPage, 0, pdwActualEnd ) ; - TRACE_DEBUG( "Actual lock range is 0x%06X - 0x%06X\n\r", *pdwActualStart, *pdwActualEnd ) ; + TRACE_DEBUG( "Actual lock range is 0x%06lX - 0x%06lX\n\r", *pdwActualStart, *pdwActualEnd ) ; } diff --git a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c index 4f772be..4467cc9 100644 --- a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c +++ b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c @@ -68,7 +68,7 @@ { uint8_t u8 = g_dfu->state; - TRACE_DEBUG("handle_getstate(%u)\n\r", g_dfu->state); + TRACE_DEBUG("handle_getstate(%lu)\n\r", g_dfu->state); USBD_Write(0, (char *)&u8, sizeof(u8), NULL, 0); } diff --git a/firmware/libcommon/source/host_communication.c b/firmware/libcommon/source/host_communication.c index ea573bb..c305b80 100644 --- a/firmware/libcommon/source/host_communication.c +++ b/firmware/libcommon/source/host_communication.c @@ -40,7 +40,7 @@ local_irq_save(x); bep->in_progress--; local_irq_restore(x); - TRACE_DEBUG("%u: in_progress=%d\n", bep->ep, bep->in_progress); + TRACE_DEBUG("%u: in_progress=%lu\n", bep->ep, bep->in_progress); if (status != USBD_STATUS_SUCCESS) TRACE_ERROR("%s error, status=%d\n", __func__, status); @@ -79,7 +79,7 @@ local_irq_restore(x); - TRACE_DEBUG("%s (EP=0x%02x), in_progress=%d\r\n", __func__, ep, bep->in_progress); + TRACE_DEBUG("%s (EP=0x%02x), in_progress=%lu\r\n", __func__, ep, bep->in_progress); msg->dst = bep; @@ -92,7 +92,7 @@ local_irq_save(x); bep->in_progress--; local_irq_restore(x); - TRACE_DEBUG("%02x: in_progress=%d\n", bep->ep, bep->in_progress); + TRACE_DEBUG("%02x: in_progress=%lu\n", bep->ep, bep->in_progress); return 0; } @@ -106,7 +106,7 @@ struct msgb *msg = (struct msgb *) arg; struct usb_buffered_ep *bep = msg->dst; - TRACE_DEBUG("%s (EP=%u, len=%u, q=%p)\r\n", __func__, + TRACE_DEBUG("%s (EP=%u, len=%lu, q=%p)\r\n", __func__, bep->ep, transferred, &bep->queue); bep->in_progress = 0; diff --git a/firmware/libcommon/source/simtrace_iso7816.c b/firmware/libcommon/source/simtrace_iso7816.c index 8ee3f8c..dc41c08 100644 --- a/firmware/libcommon/source/simtrace_iso7816.c +++ b/firmware/libcommon/source/simtrace_iso7816.c @@ -109,7 +109,7 @@ /* Fill char into buffer */ rbuf_write(&sim_rcv_buf, c); } else { - TRACE_DEBUG("e %x st: %x\n", c, stat); + TRACE_DEBUG("e %x st: %lx\n", c, stat); } /* else: error occurred */ char_stat = stat; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I924a16f03e2a099b9f8eb56746bff2b9101c6802 Gerrit-Change-Number: 16570 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191214/73998dfd/attachment.htm>