This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297 )
Change subject: msc: add tests for SMS and voice call while Paging
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297/2/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297/2/msc/MSC_Tests.ttcn@173
PS2, Line 173: f_vty_transceive(MSCVTY, "logp lglobal notice " & log_msg);
What about this MSCVTY? I would prefer to not have to pass that as argument all the time,
Seems good enough to me to "code dup" these two lines to each FOO_ConnHdlr context?
If it's too controversial I could also drop this part into a separate patch and only log() below...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297/2/msc/MSC_Tests.ttcn@1892
PS2, Line 1892: spars.tp.ud := 'C8329BFD064D9B53'O;
re below comment: same PDU as here, and see the "Hello SMS" above that this represents in, what, a septet stream or similar nightmare.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297/2/msc/MSC_Tests.ttcn@1941
PS2, Line 1941: spars.tp.ud := '41F79B8E2ECB41D3E614'O;
("Another SMS")
I guess I would have put comments next to it if the previous code I copied from had them.
Seems obvious enough, right?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieeae6322d4e80893ea3408c6b74bf8e32bea8e46
Gerrit-Change-Number: 16297
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Dec 2019 15:20:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191212/de38ad33/attachment.htm>