Change in osmo-ttcn3-hacks[master]: pcu: add TC_paging_cs_from_bts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Dec 10 08:18:10 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 )

Change subject: pcu: add TC_paging_cs_from_bts
......................................................................


Patch Set 5:

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/library/RLCMAC_Types.ttcn 
File library/RLCMAC_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/library/RLCMAC_Types.ttcn@424 
PS5, Line 424: MAC_PT_RLCMAC_NO_OPT
(MAC_PT_RLCMAC_NO_OPT, MAC_PT_RLCMAC_OPT)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn@1619 
PS5, Line 1619: MobileL3_CommonIE_Types
No need to use this prefix as you're importing all from MobileL3_CommonIE_Types.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn@1653 
PS5, Line 1653: :=
cosmetic: space is missing


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn@1661 
PS5, Line 1661: len
So we only compare the lengths? Can we compare the identities too?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia3ad503c243c9b3b162e204683fa4fa5447bbab3
Gerrit-Change-Number: 15623
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Assignee: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Dec 2019 08:18:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191210/0715053e/attachment.htm>


More information about the gerrit-log mailing list