Change in osmo-ttcn3-hacks[master]: pcu: Verify contents of data dl blocks originated from emulated SGSN

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16485 )

Change subject: pcu: Verify contents of data dl blocks originated from emulated SGSN
......................................................................

pcu: Verify contents of data dl blocks originated from emulated SGSN

Change-Id: I4fe79572094038cbb26d5195c0544846ca2550b5
---
M pcu/PCU_Tests_RAW.ttcn
1 file changed, 22 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index 410dc31..cddf9f6 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -759,13 +759,34 @@
 runs on RAW_PCU_Test_CT {
 	var template RlcmacDlBlock dl_template := tr_RLCMAC_DATA_RRBP;
 	dl_template.data.blocks := ?;
-	/* TODO: match data correctly: { valueof(t_RLCMAC_LLCBLOCK(data)) }; */
 
 	f_rx_rlcmac_dl_block(dl_block);
 	if (not match(dl_block, dl_template)) {
 		setverdict(fail, "Failed to match Packet data: ", dl_block, " vs ", dl_template);
 		mtc.stop;
 	}
+
+	if (lengthof(dl_block.data.blocks) < 1) {
+		setverdict(fail, "DL block has no LLC payload: ", dl_block);
+		mtc.stop;
+	}
+
+	if (ispresent(dl_block.data.blocks[0].hdr) and dl_block.data.blocks[0].hdr.length_ind != lengthof(data)) {
+		setverdict(fail, "DL block has LLC header with wrong expected size: ",
+			   dl_block.data.blocks[0].hdr.length_ind, " vs ", lengthof(data));
+		mtc.stop;
+	}
+
+	if (dl_block.data.blocks[0].payload != data) {
+		setverdict(fail, "Failed to match content of LLC payload in DL Block: ", dl_block, " vs ", data);
+		mtc.stop;
+	}
+
+	/* Check next data blocks contain dummy frames */
+	if (lengthof(dl_block.data.blocks) > 1 and substr(dl_block.data.blocks[1].payload, 0, 3) != '43C001'O) {
+		setverdict(fail, "Second data payload is not a dummy frame: ", dl_block.data.blocks[1].payload);
+		mtc.stop;
+	}
 }
 
 testcase TC_pcuif_suspend() runs on RAW_PCU_Test_CT {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16485
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4fe79572094038cbb26d5195c0544846ca2550b5
Gerrit-Change-Number: 16485
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191206/bb44b2e9/attachment.htm>