Change in osmo-ttcn3-hacks[master]: pcu: send UL CONTROL ACK triggered by DL ACK/NACK

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Dec 5 18:00:02 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501 )

Change subject: pcu: send UL CONTROL ACK triggered by DL ACK/NACK
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Sorry, I don't like this approach. It basically makes 1/10 use cases look shorter, while the rest 9/10 ones have to use a dummy variable.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501/3/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501/3/pcu/PCU_Tests_RAW.ttcn@744 
PS3, Line 744: dl_block
You've already exposed the whole RlcmacDlBlock, so the callers access dl_block.ctrl.mac_hdr.rrbp themselves if they need it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib409394257427cfc62da08fe06ce6c001dcf608a
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 18:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191205/46d93bd4/attachment.htm>


More information about the gerrit-log mailing list