Change in osmo-sgsn[master]: exit(2) on unsupported positional arguments on command line

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16456 )


Change subject: exit(2) on unsupported positional arguments on command line
......................................................................

exit(2) on unsupported positional arguments on command line

Change-Id: I4f2d70d0b0f1b7bdb8604c930aba8fbb53d8bd54
---
M src/gbproxy/gb_proxy_main.c
M src/gtphub/gtphub_main.c
M src/sgsn/sgsn_main.c
3 files changed, 15 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/56/16456/1

diff --git a/src/gbproxy/gb_proxy_main.c b/src/gbproxy/gb_proxy_main.c
index 4319fda..8c83980 100644
--- a/src/gbproxy/gb_proxy_main.c
+++ b/src/gbproxy/gb_proxy_main.c
@@ -196,6 +196,11 @@
 			break;
 		}
 	}
+
+	if (argc > optind) {
+		fprintf(stderr, "Unsupported positional arguments on command line\n");
+		exit(2);
+	}
 }
 
 int gbproxy_vty_is_config_node(struct vty *vty, int node)
diff --git a/src/gtphub/gtphub_main.c b/src/gtphub/gtphub_main.c
index f693f09..664c801 100644
--- a/src/gtphub/gtphub_main.c
+++ b/src/gtphub/gtphub_main.c
@@ -322,6 +322,11 @@
 			break;
 		}
 	}
+
+	if (argc > optind) {
+		fprintf(stderr, "Unsupported positional arguments on command line\n");
+		exit(2);
+	}
 }
 
 int main(int argc, char **argv)
diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c
index 7d9a851..3b18b05 100644
--- a/src/sgsn/sgsn_main.c
+++ b/src/sgsn/sgsn_main.c
@@ -271,6 +271,11 @@
 			break;
 		}
 	}
+
+	if (argc > optind) {
+		fprintf(stderr, "Unsupported positional arguments on command line\n");
+		exit(2);
+	}
 }
 
 /* default categories */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/16456
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4f2d70d0b0f1b7bdb8604c930aba8fbb53d8bd54
Gerrit-Change-Number: 16456
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191203/01491a6a/attachment.htm>