Change in osmo-e1-recorder[master]: exit(2) on unsupported positional arguments on command line

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16453 )


Change subject: exit(2) on unsupported positional arguments on command line
......................................................................

exit(2) on unsupported positional arguments on command line

Change-Id: I6d4efa6ddef41607aecd5ceee78e400db821292f
---
M src/e1_recorder.c
M src/e1cap_dump.c
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder refs/changes/53/16453/1

diff --git a/src/e1_recorder.c b/src/e1_recorder.c
index 1afd40d..5986901 100644
--- a/src/e1_recorder.c
+++ b/src/e1_recorder.c
@@ -171,6 +171,11 @@
 			break;
 		}
 	}
+
+	if (argc > optind) {
+		fprintf(stderr, "Unsupported positional arguments on command line\n");
+		exit(2);
+	}
 }
 
 int main(int argc, char **argv)
diff --git a/src/e1cap_dump.c b/src/e1cap_dump.c
index 2d9249e..68460ab 100644
--- a/src/e1cap_dump.c
+++ b/src/e1cap_dump.c
@@ -297,6 +297,11 @@
 		exit(2);
 	}
 
+	if (argc > optind+1) {
+		fprintf(stderr, "Unsupported positional arguments on command line\n");
+		exit(2);
+	}
+
 	f = osmo_e1cap_open(NULL, argv[optind++]);
 	if (!f) {
 		fprintf(stderr, "Unable to open input file\n");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16453
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-recorder
Gerrit-Branch: master
Gerrit-Change-Id: I6d4efa6ddef41607aecd5ceee78e400db821292f
Gerrit-Change-Number: 16453
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191203/af61a27d/attachment.htm>