Change in osmo-remsim[master]: bankd: send IPA CCM ID_ACK after receiving ID_ACK

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/16434 )

Change subject: bankd: send IPA CCM ID_ACK after receiving ID_ACK
......................................................................

bankd: send IPA CCM ID_ACK after receiving ID_ACK

It is customary in the IPA protocol that a a server side
responds with an ID_ACK if the client sends an ID_ACK.  Due
to the lack of any protocol specification, it's unclear why
exactly, but we know it does happen.

osmo-remsim-bankd so far failed to implement this, which is
not directly a problem as the only user (osmo-remsim-client)
didn't care.  However, when executing TTCN3 test cases,
the IPA_Emulation expects that ID_ACK and related test fail.

Change-Id: Ie55c9d5c435df786e97ec3900837bb21ab80140a
---
M src/bankd/bankd_main.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c
index 8cfeb96..9f99f83 100644
--- a/src/bankd/bankd_main.c
+++ b/src/bankd/bankd_main.c
@@ -747,6 +747,8 @@
 		switch (hh->data[0]) {
 		case IPAC_MSGT_PING:
 			return ipa_ccm_send_pong(worker->client.fd);
+		case IPAC_MSGT_ID_ACK:
+			return ipa_ccm_send_id_ack(g_worker->client.fd);
 		default:
 			LOGW(worker, "IPA CCM 0x%02x not implemented yet\n", hh->data[0]);
 			break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/16434
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ie55c9d5c435df786e97ec3900837bb21ab80140a
Gerrit-Change-Number: 16434
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191203/04ba3a20/attachment.htm>