Change in osmo-remsim[master]: cosmetic: more comments; spelling fixes in comments

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/16433 )


Change subject: cosmetic: more comments; spelling fixes in comments
......................................................................

cosmetic: more comments; spelling fixes in comments

Change-Id: I4939a386ac48e4e66bce9784d9a1539426c41aae
---
M src/bankd_client_fsm.c
M src/rspro_client_fsm.c
2 files changed, 16 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/33/16433/1

diff --git a/src/bankd_client_fsm.c b/src/bankd_client_fsm.c
index 2e3fdc9..7ddc065 100644
--- a/src/bankd_client_fsm.c
+++ b/src/bankd_client_fsm.c
@@ -63,15 +63,18 @@
 }
 
 /***********************************************************************
- * bankd connection FSM: Remsim Client connection to Bankd
+ * client-side FSM for RSPRO connection to remsim-bankd
+ *
+ * This is part of remsim-client and manages the connection to remsim-bankd,
+ * over which actual TPDU exchanges happen.
  ***********************************************************************/
 
 enum bankd_conn_fsm_state {
-	/* waiting for initial connectiong to remsim-bankd */
+	/* waiting for initial connection to remsim-bankd */
 	BDC_ST_INIT,
 	/* bankd connection established, waiting for ClientConnectRes */
 	BDC_ST_ESTABLISHED,
-	/* bankd connection etsablished, ClientConnect succeeded */
+	/* bankd connection established, ClientConnect succeeded */
 	BDC_ST_CONNECTED,
 	/* connection lost, we're waiting for a re-establish */
 	BDC_ST_REESTABLISH,
diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index c01a763..7045778 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -44,7 +44,16 @@
 #define T2_RECONNECT			10
 
 /***********************************************************************
- * server connection FSM: remsim-{client,bankd} to remsim-server
+ * client-side FSM for a RSPRO connection to remsim-server
+ *
+ * This implements the TCP/IPA client side of an RSPRO connection between
+ * a logical (TCP-level) client implementation and a remote RSPRO server.
+ *
+ * 'client' and 'server' here strictly refer to RSPRO protocol roles, not
+ * to be confused with the remsim-client or remsim-server!
+ *
+ * Specifically, this RSPRO client FSM is used by both remsim-client and
+ * remsim-bankd for their RSPRO control connection to remsim-server.
  ***********************************************************************/
 
 static void push_and_send(struct ipa_client_conn *ipa, struct msgb *msg_tx)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/16433
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I4939a386ac48e4e66bce9784d9a1539426c41aae
Gerrit-Change-Number: 16433
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191203/b32fe567/attachment.htm>